network: fix TestSlowPeerDisconnection regression after #5634 #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/wsnet-slowpeer-test-fix
branch
from
387f8f5 to
2574f70
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5874 +/- ##
==========================================
- Coverage 55.91% 55.91% -0.01%
==========================================
Files 477 477
Lines 67407 67407
==========================================
- Hits 37689 37688 -1
+ Misses 27157 27156 -1
- Partials 2561 2563 +2 ☔ View full report in Codecov by Sentry. |
jannotti
approved these changes
Dec 16, 2023
jasonpaulos
approved these changes
Dec 18, 2023
gmalouf
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wsNetwork refactoring changed the
slowWritingPeerMonitorIntervalvalue inTestSlowPeerDisconnection: it got overwritten inwn.setupby 5s default value that caused test fail time to time when the wait time as a bit greater than 5s.Failure examples: one, two
Test Plan
This is a test fix.