AVM: Don't treat any as constant int in loads, stores
#5884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
force-pushed
the
type-check-fix
branch
from
8e3890c to
cd64d33
Compare
algorandskiy
approved these changes
Dec 21, 2023
jasonpaulos
approved these changes
Dec 21, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5884 +/- ##
==========================================
- Coverage 55.96% 55.95% -0.02%
==========================================
Files 477 477
Lines 67400 67400
==========================================
- Hits 37720 37713 -7
- Misses 27126 27134 +8
+ Partials 2554 2553 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deciding how to propagate type into in
loadsandstoreswe sometimes thought we had a constant index to work with even when we didn't.Regression unit test added.