Dryrun: Improve assembler error reporting #5889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I know this code is not necessarily in heavy use anymore, but I had a frustrating experience debugging a pyteal integration test that uses dryrun.
If there's more than one assembler error in a TEAL dryrun source, dryrun returns the error directly from
logic.AssembleString
, which unhelpfully only tells you the number of errors:go-algorand/data/transactions/logic/assembler.go
Line 2154 in 3a80a40
I fixed this by using the
ReportMultipleErrors
function to build a more informative string, like other callsites do.Test Plan
Unit test added