Tests: Thread testing.T through so we panic less #5938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same tests, nicer output, and we can see multiple failures, since we don't panic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5938 +/- ##
==========================================
+ Coverage 55.68% 55.71% +0.03%
==========================================
Files 487 487
Lines 68048 68048
==========================================
+ Hits 37894 37916 +22
+ Misses 27578 27570 -8
+ Partials 2576 2562 -14 ☔ View full report in Codecov by Sentry. |
jasonpaulos
approved these changes
Feb 15, 2024
algorandskiy
approved these changes
Feb 15, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same tests, nicer output, and we can see multiple failures, since we don't panic.
Ran into tests that were hard to understand because they panic'ed while doing incentive work. This PR breaks out the very repetitive changes to use `require.