p2p: add telemetry and DHT/libp2p metrics #5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5941 +/- ##
===============================================
+ Coverage 55.91% 56.00% +0.09%
===============================================
Files 493 495 +2
Lines 68699 68890 +191
===============================================
+ Hits 38413 38582 +169
- Misses 27672 27689 +17
- Partials 2614 2619 +5 ☔ View full report in Codecov by Sentry. |
algorandskiy
force-pushed
the
pavel/p2p-telemetry
branch
from
edb4744
to
06e6c70
Compare
algorandskiy
changed the title
jasonpaulos
reviewed
Feb 27, 2024
jasonpaulos
approved these changes
Feb 27, 2024
algorandskiy
force-pushed
the
pavel/p2p-telemetry
branch
2 times, most recently
from
f0a62ee
to
fc7dcff
Compare
algorandskiy
force-pushed
the
pavel/p2p-telemetry
branch
from
fc1c8f0
to
3e6bf24
Compare
algorandskiy
changed the title
algorandskiy
force-pushed
the
pavel/p2p-telemetry
branch
from
22dfa7c
to
2f030ef
Compare
algorandskiy
force-pushed
the
pavel/p2p-telemetry
branch
from
2f030ef
to
d144fc7
Compare
|
Pulled master into |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add missing p2p telemetry similarly to wsNetwork:
sendPeerConnectionsTelemetryStatusfrom wsNetIn order to propagate telemetryID and instanceName provided by logging module, p2p peers expose a fake
/algorand-telemetry/1.0.0/{TID}/{INSTANCE}protocol so that remote side can discover it and treat as some extra meta information. This is a workaround for HTTP transport with its custom HTTP headers.Add DHT stats collected with OpenCensus (so that a new dependency):
Metric-compatible type when gatheredAdd libp2p prometheus metrics gathering. Supporting only counters and gauges (missing histograms, similarly to DHT).
Test Plan
Added unit tests for telemetryID/instanceName functionality.
Added a unit test for stats similar to what DHT uses.
Added a unit test for metrics similar to what libp2p uses.