p2p: refactor gossipsub to validation and handling #5976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5976 +/- ##
===============================================
- Coverage 55.97% 55.24% -0.74%
===============================================
Files 495 495
Lines 68896 69009 +113
===============================================
- Hits 38562 38121 -441
- Misses 27708 28273 +565
+ Partials 2626 2615 -11 ☔ View full report in Codecov by Sentry. |
algorandskiy
changed the title
This reverts commit 439e89e.
algorandskiy
force-pushed
the
pavel/p2p-gossipsub-validate
branch
from
244694f
to
2b4e304
Compare
jasonpaulos
reviewed
May 7, 2024
| @@ -24,32 +24,55 @@ import ( | |||
| // Multiplexer is a message handler that sorts incoming messages by Tag and passes | |||
| // them along to the relevant message handler for that type of message. | |||
| type Multiplexer struct { | |||
| msgHandlers atomic.Value // stores map[Tag]MessageHandler, an immutable map. | |||
| msgHandlers atomic.Value // stores map[Tag]MessageHandler, an immutable map. | |||
| msgProcessors atomic.Value // stores map[Tag]MessageProcessor, an immutable map. | |||
There was a problem hiding this comment.
It's probably worth updating network/multiplexer_test.go as well
|
tools cross-check fails but this is OK since the entire p2p branch needs updates from |
cce
reviewed
May 10, 2024
cce
reviewed
May 10, 2024
cce
reviewed
May 10, 2024
cce
reviewed
May 10, 2024
cce
reviewed
May 10, 2024
cce
reviewed
May 10, 2024
cce
approved these changes
May 10, 2024
cce
reviewed
May 10, 2024
| var isDup bool | ||
| if handler.msgCache != nil { | ||
| // check for duplicate messages | ||
| // this helps against relaying duplicates | ||
| if msgKey, isDup = handler.msgCache.CheckAndPut(rawmsg.Data); isDup { | ||
| if msgKey, isDup = handler.msgCache.CheckAndPut(data); isDup { |
There was a problem hiding this comment.
gossipsub has its own duplicate checker too, depending on the message hash function implementation? I wonder how often you will hit this when gossipsub is in front of it
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MessageProcessorsimilar toMessageHandlerbut working in two stages: validate and handleprocessIncomingTxntxhandler method into two validate + handleTest Plan