Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils: Renaming files across devices #5977

Merged
merged 8 commits into from
Apr 17, 2024

Conversation

jasonpaulos
Copy link
Contributor

@jasonpaulos jasonpaulos commented Apr 16, 2024

Summary

This PR contains a bugfix for renaming files across devices.

Test Plan

Unit tests added

util/io.go Outdated Show resolved Hide resolved
util/io.go Outdated Show resolved Hide resolved
util/io.go Outdated Show resolved Hide resolved
util/io.go Outdated Show resolved Hide resolved
util/io.go Show resolved Hide resolved
util/io.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 56.03%. Comparing base (dfd95ff) to head (eab29c0).

Files Patch % Lines
util/io.go 63.63% 7 Missing and 5 partials ⚠️
config/localTemplate.go 0.00% 0 Missing and 1 partial ⚠️
logging/cyclicWriter.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5977      +/-   ##
==========================================
+ Coverage   56.00%   56.03%   +0.03%     
==========================================
  Files         481      481              
  Lines       67646    67679      +33     
==========================================
+ Hits        37883    37924      +41     
+ Misses      27197    27188       -9     
- Partials     2566     2567       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonpaulos jasonpaulos marked this pull request as ready for review April 16, 2024 17:35
algorandskiy
algorandskiy previously approved these changes Apr 16, 2024
util/io.go Show resolved Hide resolved
util/io_test.go Outdated Show resolved Hide resolved
@jasonpaulos jasonpaulos merged commit c07f2d5 into algorand:master Apr 17, 2024
19 checks passed
@jasonpaulos jasonpaulos deleted the move-file-fix branch April 17, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants