Testing: Allow go e2e tests to easily test multiple consensus versions #5981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
changed the title
devmode_test.test.go was converted as an example. Perhaps we should provide a helper to test several versions. Input especially solicited on the idea of only running on "future" when testing.Short. Smae idea could speed up our normal unit tests that use TestConsensusRange.
jannotti
force-pushed
the
e2e-go-overrides
branch
from
1ed8c58 to
b160d7a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5981 +/- ##
==========================================
- Coverage 56.05% 55.97% -0.08%
==========================================
Files 481 481
Lines 67679 67685 +6
==========================================
- Hits 37936 37888 -48
- Misses 27177 27221 +44
- Partials 2566 2576 +10 ☔ View full report in Codecov by Sentry. |
ohill
previously approved these changes
Apr 19, 2024
ohill
reviewed
Apr 19, 2024
jannotti
force-pushed
the
e2e-go-overrides
branch
from
322f520 to
1acf8a9
Compare
algorandskiy
approved these changes
Apr 19, 2024
ohill
approved these changes
Apr 26, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devmode_test.test.go was converted as an example. Perhaps we should provide a helper to test several versions.
Input especially solicited on the idea of only running on "future" when testing.Short. Smae idea could speed up our normal unit tests that use TestConsensusRange.
Summary
Test Plan