Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make e2e TestBasicSuspension less flaky #5995

Merged
merged 2 commits into from
May 9, 2024

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented May 9, 2024

Summary

Failure:

    fixture.go:120: 
        	Error Trace:	/opt/cibuild/project/test/e2e-go/features/incentives/suspension_test.go:122
        	Error:      	Not equal: 
        	            	expected: 0x0
        	            	actual  : 0x1
        	Test:       	TestBasicSuspension

Fix is to sync all test clients before proceeding, the same idea as #5986

Test Plan

This is a test fix

gmalouf
gmalouf previously approved these changes May 9, 2024
jasonpaulos
jasonpaulos previously approved these changes May 9, 2024
@algorandskiy algorandskiy dismissed stale reviews from jasonpaulos and gmalouf via 3ef0cb7 May 9, 2024 18:08
@gmalouf gmalouf requested review from gmalouf and jasonpaulos May 9, 2024 18:15
@algorandskiy algorandskiy merged commit c7d281e into algorand:master May 9, 2024
16 checks passed
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.90%. Comparing base (6c91f52) to head (3ef0cb7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5995      +/-   ##
==========================================
- Coverage   55.94%   55.90%   -0.05%     
==========================================
  Files         482      482              
  Lines       68310    68310              
==========================================
- Hits        38219    38189      -30     
- Misses      27500    27523      +23     
- Partials     2591     2598       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants