ledger: introduce expired stake cache #6014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
changed the title
cce
previously approved these changes
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6014 +/- ##
==========================================
+ Coverage 55.94% 55.96% +0.01%
==========================================
Files 482 483 +1
Lines 68310 68336 +26
==========================================
+ Hits 38219 38247 +28
Misses 27500 27500
+ Partials 2591 2589 -2 ☔ View full report in Codecov by Sentry. |
algorandskiy
commented
Jun 5, 2024
cce
previously approved these changes
Jun 6, 2024
onetechnical
approved these changes
Jun 6, 2024
cce
reviewed
Jun 6, 2024
gmalouf
reviewed
Jun 7, 2024
cce
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a simple two-page cache for expired account stake since the underlying query is quite expensive.
Test Plan
Added new unit tests for the cache and extended existing test to check its use.