Tools: Fix Cloudflare SRV update utility after API change #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tried provisioning some small network like hello-word from |
gmalouf
approved these changes
Jun 7, 2024
|
init_wallet_handle fix #6021 |
Yes, seems to work. |
algorandskiy
approved these changes
Jun 7, 2024
|
I suggest to force merge it since there is a known non-related e2e-subs tests flakiness. |
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cloudflare deprecated a few data fields on SRV records, relying on a name field incorporating them. This PR updates the Cloudflare library utility to remove the deprecated data fields and add a Name field. See also:
https://developers.cloudflare.com/fundamentals/api/reference/deprecations/#name-related-data-fields-on-srv-dns-records
Test Plan
Tested using internal tooling to verify functionality.