-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: hybrid node net identity for connection deduplication #6035
p2p: hybrid node net identity for connection deduplication #6035
Conversation
a4f5239
to
7ab2f51
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6035 +/- ##
==========================================
+ Coverage 56.12% 56.30% +0.17%
==========================================
Files 488 488
Lines 69474 69581 +107
==========================================
+ Hits 38994 39178 +184
+ Misses 27831 27749 -82
- Partials 2649 2654 +5 ☔ View full report in Codecov by Sentry. |
While implementing this I noticed p2p peerID is not really used because
// if the address is not meant for this host, return without attaching headers,
// but also do not emit an error. This is because if an operator were to incorrectly
// specify their dedupName, it could result in inappropriate disconnections from valid peers
if _, ok := i.dedupNames[string(idChal.Msg.PublicAddress)]; !ok {
return identityChallengeValue{}, crypto.PublicKey{}, nil
} I thought about eliminating it completely from challenge scheme but it requires more investigation. |
ab1d0bd
to
0eca7c1
Compare
Rebased/fixed merge conflicts |
4067026
to
fd9bff1
Compare
rebased on top of feature/p2p |
2e10580
to
5d82ec4
Compare
rebased to fix build errors |
5d82ec4
to
ed5e936
Compare
Added a stub
|
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments
Fixed CR notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise I think this is okay. Worth doublechecking all the config cases are covered.
Co-authored-by: Gary Malouf <982483+gmalouf@users.noreply.github.com>
Summary
EnableP2PHybridMode
also requiresPublicAddress
to be set on nodes listeningNetAddress
orP2PNetAddress
netdeploy
gossipSubPeer
type because of type cast in hybrid mode causing panic (see in comments)PublicAddress
from config with netAddr fetched from DNS.Test Plan
Added new unit tests and run cluster tests.
Pulled TODOs from #5939
Validated deduplication in logs, found and fixed PublicAddress vs DNS netAddr letter case issue.
scenario1s half: 4R+4N+4NPN results: