P2P: Disable circuit relaying via libp2p.NoListenAddrs #6064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6064 +/- ##
==========================================
+ Coverage 56.11% 56.15% +0.03%
==========================================
Files 488 488
Lines 69437 69434 -3
==========================================
+ Hits 38966 38990 +24
+ Misses 27821 27798 -23
+ Partials 2650 2646 -4 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Jul 12, 2024
onetechnical
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR simply disables circuit relaying via libp2p.NoListenAddrs in either p2p or hybrid operating modes. More information on circuit relaying can be found at https://docs.libp2p.io/concepts/nat/circuit-relay/.
Test Plan
Existing tests should pass.