-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rest api: Fix to Disable API authentication #6067
rest api: Fix to Disable API authentication #6067
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6067 +/- ##
==========================================
+ Coverage 55.77% 56.17% +0.39%
==========================================
Files 488 488
Lines 69434 69437 +3
==========================================
+ Hits 38730 39008 +278
+ Misses 28017 27791 -226
+ Partials 2687 2638 -49 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me. The auth middleware gets disabled on public AI endpoints if no token is passed at startup (noting that admin auth still gets enabled int he proper places). Small comments to look at before approving.
closes #5747 |
Co-authored-by: Gary Malouf <982483+gmalouf@users.noreply.github.com>
Summary
Fix to #5625 where incorrect test with a client always using an adminToken lead to incorrect actual implementation.
Test Plan
Fixed an existing e2e test