Testing: Move WaitForConfirmedTxn down into clients #6218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
changed the title
Allows for more consistent communication with nodes during tests
jannotti
force-pushed
the
client-waitfortxn
branch
from
92e84ed to
8d71f3e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6218 +/- ##
==========================================
- Coverage 51.94% 51.88% -0.06%
==========================================
Files 643 643
Lines 86242 86267 +25
==========================================
- Hits 44795 44763 -32
- Misses 38584 38635 +51
- Partials 2863 2869 +6 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Jan 8, 2025
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for more consistent communication with nodes during tests
This allows tests to keep talking to the same node, so that when they wait for a round, their next api call is sure to go to the node that has committed that round. It also simplifies a lot of code that otherwise needs a RestClientFixture and a libgoal.Client.
Summary
Test Plan