Testing: Don't fail for heartbeat in same block as proposal #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6229 +/- ##
==========================================
- Coverage 51.85% 50.99% -0.87%
==========================================
Files 643 643
Lines 86384 86384
==========================================
- Hits 44797 44051 -746
- Misses 38723 39453 +730
- Partials 2864 2880 +16 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Jan 15, 2025
gmalouf
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes another flaky possibility. In case it doesn't, it also adds a bit more logging to further debug.
Summary
Test Plan