Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB: Remove AtomicContextWithRetryClearFn, rename to AtomicContext #6231

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

cce
Copy link
Contributor

@cce cce commented Jan 17, 2025

Summary

This implements some PR feedback from @gmalouf in #6190 (comment) to remove an unnecessary extra function wrapper when using db.AtomicContext function

Test Plan

Existing tests should pass

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.84%. Comparing base (d52e3dd) to head (243bfd6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...edger/store/trackerdb/sqlitedriver/sqlitedriver.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6231   +/-   ##
=======================================
  Coverage   51.84%   51.84%           
=======================================
  Files         643      643           
  Lines       86384    86382    -2     
=======================================
+ Hits        44783    44787    +4     
+ Misses      38737    38729    -8     
- Partials     2864     2866    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmalouf
gmalouf previously approved these changes Jan 17, 2025
@gmalouf gmalouf requested a review from jannotti January 22, 2025 16:18
@gmalouf gmalouf merged commit a81d54f into algorand:master Jan 23, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants