Skip to content

Conversation

@onetechnical
Copy link
Contributor

@onetechnical onetechnical commented Mar 31, 2025

Summary

If you run go mod tidy with newer versions of golang, it will automatically change the minimum version field in go.mod. Before, this would be e.g. 1.23, but after update, it will change this to 1.23.0.

Our bash scripts needed to be updated to take this into account. The following changes were made:

  • Removed third parameter from ./scripts/get_golang_version.sh all. This was so ./scripts/check_golang_version.sh could check for go module support, so I just moved the version information there
  • Updated Makefile to reflect this
  • Fixed conditionals in check_golang_version.sh to properly compare semantic versions

Test Plan

Set a custom version in check_golang_version.sh and verified:

  • 1.2.0 reported error
  • 1.12.0 reported warning for ./scripts/check_golang_version.sh dev
  • 1.12.0 errored for ./scripts/check_golang_version.sh build
  • 1.23.0 did not error

- Remove go modules version from get_golang_version.sh
- Correctly check semantic versioning in check_golang_version.sh
@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.67%. Comparing base (160bcf3) to head (3c3775e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6288      +/-   ##
==========================================
+ Coverage   51.65%   51.67%   +0.01%     
==========================================
  Files         649      649              
  Lines       86857    86857              
==========================================
+ Hits        44868    44880      +12     
+ Misses      39128    39112      -16     
- Partials     2861     2865       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@onetechnical onetechnical merged commit f8ec83f into master Apr 1, 2025
23 of 27 checks passed
@onetechnical onetechnical deleted the fix-go-mod branch April 1, 2025 15:56
onetechnical added a commit to onetechnical/go-algorand that referenced this pull request Apr 8, 2025
cce pushed a commit to cce/go-algorand that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants