Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented May 20, 2025

Summary

Now that #6276 and #6312 have been merged, the configuration to enable vote compression needs to be wired up to the P2PNetwork implementation, and this is the missing initialization to do so.

Test Plan

Network performance testing, plus new unit test TestP2PVoteCompression.

@cce cce changed the title network: enable vote compression for p2pNetwork network: enable vote compression for P2PNetwork May 20, 2025
algorandskiy
algorandskiy previously approved these changes May 20, 2025
@cce cce force-pushed the p2p-vote-compression branch from c75e7a9 to 409b2a7 Compare May 20, 2025 18:39
@cce cce marked this pull request as draft May 20, 2025 18:43
algorandskiy
algorandskiy previously approved these changes May 20, 2025
@cce cce marked this pull request as ready for review May 20, 2025 19:01
algorandskiy
algorandskiy previously approved these changes May 20, 2025
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.86%. Comparing base (ad67b95) to head (8f9d209).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6331      +/-   ##
==========================================
- Coverage   51.87%   51.86%   -0.02%     
==========================================
  Files         653      653              
  Lines       87545    87547       +2     
==========================================
- Hits        45417    45404      -13     
- Misses      39260    39267       +7     
- Partials     2868     2876       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@algorandskiy algorandskiy merged commit 64ae8b0 into algorand:master May 20, 2025
20 checks passed
@cce cce deleted the p2p-vote-compression branch May 20, 2025 20:41
onetechnical pushed a commit to onetechnical/go-algorand that referenced this pull request May 20, 2025
cce added a commit to cce/go-algorand that referenced this pull request May 29, 2025
cce added a commit to cce/go-algorand that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants