Skip to content

Conversation

@knowmost
Copy link
Contributor

Summary

In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.

Test Plan

Signed-off-by: knowmost <knowmost@outlook.com>
@CLAassistant
Copy link

CLAassistant commented May 22, 2025

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.86%. Comparing base (34deef2) to head (57a9b3f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
tools/debug/carpenter/main.go 0.00% 1 Missing ⚠️
util/watchdogStreamReader.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6338   +/-   ##
=======================================
  Coverage   51.85%   51.86%           
=======================================
  Files         653      653           
  Lines       87554    87546    -8     
=======================================
+ Hits        45404    45407    +3     
+ Misses      39276    39264   -12     
- Partials     2874     2875    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jannotti jannotti merged commit 6f65ab1 into algorand:master May 23, 2025
20 of 21 checks passed
cce pushed a commit to cce/go-algorand that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants