-
Notifications
You must be signed in to change notification settings - Fork 519
network: refactor networking mesh maintaining code #6374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6374 +/- ##
==========================================
- Coverage 50.63% 47.81% -2.82%
==========================================
Files 660 654 -6
Lines 110513 110584 +71
==========================================
- Hits 55953 52875 -3078
- Misses 51704 54689 +2985
- Partials 2856 3020 +164 ☔ View full report in Codecov by Sentry. |
gmalouf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, left a few comments/questions.
bfeccf5 to
e0b68fb
Compare
|
I rewrote the hybrid strategy initialization as suggested, no ugly |
|
Pushed more CR fixes |
Summary
This PR refactors meshing code by generalizing and moving
meshThreadcode into a newmesh.gosource file and introducing a newmesherabstraction.By using this abstraction it is now possible to play with mesh creation logic for hybrid network. For example, this PR adds a new
hybridRelayMeshthat does not run p2p part meshing and just uses ws net meshing.Additionally this PR changes
NewWebsocketNetwork/NewP2PNetworkconstructors by introducingGenesisInfoin order to keep a number of parameters manageable.Test Plan
hybridRelayMeshworks as designed