Skip to content

Conversation

@algorandskiy
Copy link
Contributor

Summary

Prevent p2p from exposing own telemetry ids.

Test Plan

Existing tests

@algorandskiy algorandskiy requested a review from gmalouf July 15, 2025 18:15
@algorandskiy algorandskiy self-assigned this Jul 15, 2025
@algorandskiy algorandskiy requested a review from cce July 15, 2025 18:15
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.42%. Comparing base (94de30f) to head (f6ad709).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6381      +/-   ##
==========================================
- Coverage   50.62%   50.42%   -0.21%     
==========================================
  Files         660      653       -7     
  Lines      110513   110415      -98     
==========================================
- Hits        55952    55681     -271     
- Misses      51704    51868     +164     
- Partials     2857     2866       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be behind an option such that known nodes could choose to have it on?

@cce
Copy link
Contributor

cce commented Jul 16, 2025

We could maybe revisit this later if a concept of trusted peers is introduced. This can be seen in other libp2p network implementations, a way to have a trusted list of peers they contact (if you only want to connect to your own infra, or trusted infra you have a relationship with).

@algorandskiy algorandskiy merged commit c0c0235 into algorand:master Jul 16, 2025
33 checks passed
@algorandskiy algorandskiy added the p2p Work related to the p2p project label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement p2p Work related to the p2p project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants