Skip to content

Conversation

@cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Aug 14, 2025

Summary

This PR refactors the helpList function to use Go generics (type parameters) instead of interface{} casting, improving type safety and simplifying the calling code.

Converts helpList function to use generic type parameter V appInteractDatum
Removes manual map copying in EntryList() and ProcList() methods
Eliminates redundant type casting by leveraging generics

Test Plan

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the helpList function to use Go generics (type parameters) instead of interface{} casting, improving type safety and simplifying the calling code.

  • Converts helpList function to use generic type parameter V appInteractDatum
  • Removes manual map copying in EntryList() and ProcList() methods
  • Eliminates redundant type casting by leveraging generics

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is fine, but it amounts to a small optimization (at the expense of code size) for an almost never used feature (interact) that I'd just as soon delete entirely.

@algorandskiy algorandskiy merged commit f62cd3d into algorand:master Aug 18, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants