Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Aug 27, 2025

Summary

Fixes a regression introduced in #6286 where constructAppTxn in the pingpong perf testing tool's code was refactored to use the new RefBundle structure for txn.Access, but forgot to set the sender output arg. This caused constructAppTxn to always return an empty string, leading to "no acct" errors for all app calls in pingpong and 0 TPS for stateful_teal_* performance tests.

The fix adds the missing sender assignments:

  • Initialize sender = from at the beginning of the opt-in logic
  • Update sender = from when the from address is changed to use an already opted-in account

Test Plan

Tested manually, "no acct" error no longer appears.

@cce cce changed the title putative fix for pingpong after #6286 pingpong: fix regression when making app calls Aug 27, 2025
@cce cce added the Bug-Fix label Aug 27, 2025
@gmalouf gmalouf merged commit be41f15 into algorand:master Aug 27, 2025
61 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants