AVM: Allow 0 as app in LocalRef, specifying current app #6483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6483 +/- ##
==========================================
- Coverage 47.58% 47.43% -0.16%
==========================================
Files 666 659 -7
Lines 88478 88395 -83
==========================================
- Hits 42103 41930 -173
- Misses 43607 43692 +85
- Partials 2768 2773 +5 ☔ View full report in Codecov by Sentry. |
jannotti
force-pushed
the
allow-0-local-app-ref
branch
5 times, most recently
from
be023d6 to
38589bf
Compare
algorandskiy
previously approved these changes
Nov 7, 2025
gmalouf
reviewed
Nov 10, 2025
gmalouf
previously approved these changes
Nov 10, 2025
A localref inside of tx.Access ought to be able to use 0 for "current app". It was an oversight to prohibit it. This PR allows it, but is consensus gated. This was a slightly bigger that chnage than expected (because the access list must now be scanned at app create time for localrefs woth 0 apps, like boxes were). So a few tests are needed before this is reviewable. Also removes two consensus flags that can be assumed true now because they are strictly more lenient.
jannotti
force-pushed
the
allow-0-local-app-ref
branch
from
38589bf to
afa94b0
Compare
gmalouf
approved these changes
Nov 10, 2025
algorandskiy
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A localref inside of tx.Access ought to be able to use 0 for "current app". It was an oversight to prohibit it. This PR allows it, but is consensus gated.
Also removes two consensus flags that can be assumed true now because they are strictly more lenient.
Add, indeed this consensus flag can be removed once it has gone into effect.
Addresses #6449
Summary
Test Plan