Skip unit test TestFirstListenerSetupGetsPort8080WhenPassedPortZero #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeldovich
reviewed
Jun 21, 2019
daemon/algod/server_test.go
Outdated
| // (ex if a dev has a node running on port 8080 and runs the test, it will fail) | ||
| defaultAddr := "127.0.0.1:0" | ||
| expectedAddr := "127.0.0.1:8080" | ||
| // (execpt if a dev has a node running on port 8080 and runs the test; in that case, we can't run this test.) |
zeldovich
approved these changes
Jun 21, 2019
pzbitskiy
pushed a commit
to pzbitskiy/go-algorand
that referenced
this pull request
May 11, 2020
TEAL: fix line to field parsing
onetechnical
added a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify the unit test TestFirstListenerSetupGetsPort8080WhenPassedPortZero so that it won't fail when running on a developer machine that already has the algod process running.
Test Plan
Local execution passed with port 8080 preoccupied. Travis run pass as expected.