Prepare for Testing the ABI-Router in PyTeal #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate, remove the deprecated dry run mixins
…d... but still need the multidispatcher
* small typing fix + EncodingType * type ignores
tzaffi
commented
Feb 2, 2023
| @@ -92,186 +90,6 @@ def test_encode_abi(): | |||
| ) | |||
|
|
|||
|
|
|||
| NONSENSE = "not a valid signature" | |||
There was a problem hiding this comment.
Moved to new test file executor_test.py
added 2 commits
February 2, 2023 17:14
tzaffi
commented
Feb 3, 2023
tzaffi
commented
Feb 3, 2023
ahangsu
reviewed
Feb 3, 2023
ahangsu
reviewed
Feb 3, 2023
ahangsu
reviewed
Feb 3, 2023
ahangsu
reviewed
Feb 3, 2023
ahangsu
reviewed
Feb 3, 2023
ahangsu
reviewed
Feb 3, 2023
added 7 commits
February 5, 2023 18:23
tzaffi
commented
Feb 6, 2023
tzaffi
commented
Feb 6, 2023
| @@ -308,10 +308,9 @@ def msg(): | |||
| err\ opcode # pyteal generated err's ok | |||
| | assert\ failed\ pc= # pyteal generated assert's ok | |||
| | invalid\ ApplicationArgs\ index # failing because an app arg wasn't provided | |||
| | extract\ range\ beyond\ length\ of\ string # failing because couldn't extract when omitted final arg or jammed in tuple | |||
| | extraction\ end\ 16\ is\ beyond\ length # failing because couldn't extract when omitted final arg or jammed in tuple | |||
There was a problem hiding this comment.
error messages have changed
tzaffi
commented
Feb 6, 2023
added 3 commits
February 6, 2023 11:50
ahangsu
reviewed
Feb 6, 2023
Comment on lines
+20
to
+22
| TODO: when incorporating hypothesis strategies, we'll need a more holistic | ||
| approach that looks at relationships amongst various args. | ||
| Current approach only looks at each argument as a completely independent entity. |
There was a problem hiding this comment.
no action needed, I see hypothesis cross the PR, together with TODO, are you referring to hypothesis https://hypothesis.readthedocs.io/en/latest/data.html?
There was a problem hiding this comment.
Yes. Here's a nice video intro about it: https://www.youtube.com/watch?v=mkgd9iOiICc&ab_channel=ArjanCodes
ahangsu
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
class ABIMethodCallStrategy(formerlyclass ABIContractExecutor):graviton/abi_strategy.py(fromgraviton/blackbox.py)validate_inputs()dryrun_sequence()get()num_args()class Simulationingraviton/sim.py. See below for usage example.tests/integration/abi_router_test.pywhich contains some tests formerly intests/integration/abi_test.pybut which are -as you might guess- all about testing theRouterDryRunInspector'serror()anderror_message()which recently brokePyTeal Sibling PR
algorand/pyteal#634
TODO
Figure out the actual PR referenced above and in the CHANGELOG