Enhancement: Allowing zero length in static array (#432)

algorand · Nov 29, 2022 · 276a4ae · 276a4ae
1 parent d4ebc32
commit 276a4ae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/com/algorand/algosdk/abi/ABIType.java b/src/main/java/com/algorand/algosdk/abi/ABIType.java
@@ -9,7 +9,7 @@
 
 public abstract class ABIType {
     public static final int ABI_DYNAMIC_HEAD_BYTE_LEN = 2;
-    private static final Pattern staticArrayPattern = Pattern.compile("^(?<elemT>[a-z\\d\\[\\](),]+)\\[(?<len>[1-9][\\d]*)]$");
+    private static final Pattern staticArrayPattern = Pattern.compile("^(?<elemT>[a-z\\d\\[\\](),]+)\\[(?<len>0|[1-9][\\d]*)]$");
     private static final Pattern ufixedPattern = Pattern.compile("^ufixed(?<size>[1-9][\\d]*)x(?<precision>[1-9][\\d]*)$");
 
     /**

diff --git a/src/main/java/com/algorand/algosdk/abi/TypeArrayStatic.java b/src/main/java/com/algorand/algosdk/abi/TypeArrayStatic.java
@@ -7,8 +7,8 @@ public class TypeArrayStatic extends ABIType {
     public final int length;
 
     public TypeArrayStatic(ABIType elemType, int length) {
-        if (length < 1)
-            throw new IllegalArgumentException("static-array initialize failure: array length should be at least 1");
+        if (length < 0)
+            throw new IllegalArgumentException("static-array initialize failure: array length should be non-negative");
         this.elemType = elemType;
         this.length = length;
     }

diff --git a/src/test/java/com/algorand/algosdk/abi/TestTypes.java b/src/test/java/com/algorand/algosdk/abi/TestTypes.java
@@ -314,7 +314,7 @@ public void TestTypeFromStringInvalid() {
                 "[][][]",
                 "stuff[]",
                 // static array
-                "ufixed32x10[0]",
+                "bool[01]",
                 "byte[10 ]",
                 "uint64[0x21]",
                 // tuple