You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we want to make typed response objects available sooner, we could consider introducing a new set of functions that can be used in place of do, e.g. doTyped or execute, which would return a typed response. We could then consider deprecating and removing do in v3 -- this would arguably be a safer way of swapping the behavior, since instead of changing a function's return type, we'd be removing the function in favor of a different one.
An additional issue to consider w/ this mentioned in #533 is handling the conversion of the returned keys which include hyphens to the JS camel case keys.
Problem
Responses from the client are not automatically converted into the defined model types (for all endpoints).
We've done this for some endpoints (see
js-algorand-sdk/src/client/v2/algod/getApplicationBoxes.ts
Lines 57 to 60 in a89046a
Solution
Implement the
response.from_obj_for_encoding(body)
for all endpoints which return structured data.Dependencies
N/A
Urgency
We should group this with any other breaking changes being made in the next major version bump.
The text was updated successfully, but these errors were encountered: