Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algod: Add blockOffsetTimestamp, syncRound APIs to algod client #769

Merged

Conversation

Eric-Warehime
Copy link
Contributor

@Eric-Warehime Eric-Warehime commented Apr 24, 2023

Updates the algod client to add support for the following new APIs:

  • /v2/ledger/sync/{round} POST
  • /v2/ledger/sync/ GET
  • /v2/devmode/blocks/offset/{offset} POST
  • /v2/devmode/blocks/offset GET
  • /v2/ledger/sync GET
  • /v2/ledger/sync/{round} POST
  • /v2/ledger/sync DELETE
  • /ready

Also incorporates generated types into the model from the algod spec.

@Eric-Warehime Eric-Warehime changed the title Add blockOffsetTimestamp, syncRound APIs to algod client algod: Add blockOffsetTimestamp, syncRound APIs to algod client Apr 24, 2023
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there going to be support for the unset sync endpoint in the SDKs?

Let's also add the /ready endpoint as well

@Eric-Warehime Eric-Warehime marked this pull request as ready for review April 27, 2023 15:53
src/client/v2/algod/getSyncRound.ts Outdated Show resolved Hide resolved
tests/cucumber/steps/index.js Show resolved Hide resolved
@@ -13,4 +13,3 @@
@rekey_v1
@send
@send.keyregtxn
@simulate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahangsu just making you aware that you'll need to add back this tag in the simulate PR you're working on

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure sure, it is on my stack.

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending tests, LGTM

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/client/v2/algod/algod.ts Outdated Show resolved Hide resolved
);

Then(
'expect the request to be {string} {string}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants