Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.8.1 #248

Merged
merged 4 commits into from
Nov 23, 2020
Merged

v1.8.1 #248

merged 4 commits into from
Nov 23, 2020

Conversation

jasonpaulos
Copy link
Contributor

Added

  • Added toString and print methods to Transaction (#243).
  • Added functions to create Transactions from objects (#246).

Fixed

  • Fixed issues using the library with webpack, including switching dependencies from keccak to js-sha3 (#247).

EvanJRichard and others added 4 commits November 13, 2020 14:19
@EvanJRichard
Pretty Print function for Transaction (#243)
d030706 
If you have a built Transaction, then calling console.log(theTxn) does not give very useful information. Addresses are formatted for bytes, for example. This commit adds prettyPrint() and toString() functions on class Transaction for user-dev debug.

Review: #243
Resolves: #240
@jasonpaulos
Switch to webpack (#247)
5edd80f 
* Switch to webpack

* Fix module path

* Update chromedriver

* Move assert workaround

* Fix cucumber browser tests
@EvanJRichard
MakeFoo family of transaction-building functions get alternate FromOb…
5d4dd31 
…ject method of calling (#246)

Review: #246
Resolves: #159
@jasonpaulos
1.8.1
d0a1452
EvanJRichard
EvanJRichard approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@EvanJRichard EvanJRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme seems to cover everything ✔️
Min.js updated ✔️
Tests pass ✔️
LGTM!

@jasonpaulos jasonpaulos merged commit 7d5db3e into master Nov 23, 2020
@jasonpaulos jasonpaulos deleted the release/1.8.1 branch November 23, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanJRichard EvanJRichard EvanJRichard approved these changes

@algorotem algorotem algorotem approved these changes

Assignees
No one assigned
Labels
FDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonpaulos @EvanJRichard @algorotem