Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow signLogicSigTransaction to accept Transaction objects #290

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

jdtzmn
Copy link
Contributor

@jdtzmn jdtzmn commented Mar 5, 2021

Fixes #287 by allowing the signLogicSigTransaction function to accept Transaction objects as opposed to JS objects.

@jdtzmn jdtzmn requested a review from jasonpaulos March 5, 2021 18:58
@jdtzmn jdtzmn force-pushed the jacob/allow-logicsig-transaction-objects branch 2 times, most recently from 5bf8554 to c987262 Compare March 8, 2021 20:51
@jdtzmn jdtzmn force-pushed the jacob/allow-logicsig-transaction-objects branch from c987262 to 901bbd8 Compare March 8, 2021 21:00
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jdtzmn jdtzmn merged commit eea58c7 into develop Mar 8, 2021
@jdtzmn jdtzmn deleted the jacob/allow-logicsig-transaction-objects branch March 8, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allows signLogicSigTransaction to accept Transaction objects
2 participants