Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate algod and indexer clients to TypeScript #313

Merged
merged 9 commits into from
Mar 24, 2021

Conversation

jdtzmn
Copy link
Contributor

@jdtzmn jdtzmn commented Mar 22, 2021

This PR migrates the Algodv2 client, indexer client, and all of their request types to TypeScript.

Closes #303.

@jdtzmn jdtzmn force-pushed the jacob/service-clients-to-typescript branch 3 times, most recently from 1ccb459 to cf76ebb Compare March 22, 2021 17:18
jdtzmn added 6 commits March 22, 2021 13:25
* Add `TransactionLike` type and `instantiateTxnIfNeeded` utility method
* Add `IntDecoding` type to TypeScript definitions
* Add lint rule to flag `module.exports` and `require` statements in TypeScript files
* Encapsulate `AlgodClient` and `IndexerClient` shared structures in an abstract class `ServiceClient`
@jdtzmn jdtzmn force-pushed the jacob/service-clients-to-typescript branch from cf76ebb to 9121495 Compare March 22, 2021 17:25
src/client/v2/jsonrequest.ts Outdated Show resolved Hide resolved
src/client/v2/algod/algod.ts Outdated Show resolved Hide resolved
src/client/v2/algod/sendRawTransaction.ts Outdated Show resolved Hide resolved
src/client/v2/algod/sendRawTransaction.ts Outdated Show resolved Hide resolved
src/client/v2/algod/supply.ts Outdated Show resolved Hide resolved
src/client/v2/indexer/lookupApplications.ts Show resolved Hide resolved
src/client/v2/indexer/lookupTransactionByID.ts Outdated Show resolved Hide resolved
src/types/intDecoding.d.ts Outdated Show resolved Hide resolved
@jdtzmn jdtzmn requested a review from jasonpaulos March 23, 2021 20:06
jdtzmn added 2 commits March 23, 2021 16:51
* Remove types from jsdoc comments in `src/client/v2/algod/algod.ts`

* Improve `concatArrays` utility method to accept multiple arrays for concatenation

* Add support for TypeScript test files
@jdtzmn jdtzmn force-pushed the jacob/service-clients-to-typescript branch from 023befa to fab6d37 Compare March 23, 2021 20:52
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jdtzmn jdtzmn merged commit 65ef211 into develop Mar 24, 2021
@jdtzmn jdtzmn deleted the jacob/service-clients-to-typescript branch March 24, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Algodv2 and Indexer clients to TypeScript
2 participants