Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate logic.js to TypeScript #317

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Migrate logic.js to TypeScript #317

merged 1 commit into from
Mar 22, 2021

Conversation

jdtzmn
Copy link
Contributor

@jdtzmn jdtzmn commented Mar 22, 2021

Closes #308.

@jdtzmn jdtzmn requested a review from jasonpaulos March 22, 2021 16:30
@jdtzmn jdtzmn self-assigned this Mar 22, 2021
@jdtzmn jdtzmn force-pushed the jacob/logicjs-to-typescript branch from f1c786f to 4a47424 Compare March 22, 2021 17:14
jasonpaulos
jasonpaulos approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments about nice-to-have type annotations, but other than that everything here looks good! Feel free to merge after those additions.

src/logic/logic.ts Outdated Show resolved Hide resolved
src/logic/logic.ts Outdated Show resolved Hide resolved
@jdtzmn jdtzmn force-pushed the jacob/logicjs-to-typescript branch from 4a47424 to 80e6336 Compare March 22, 2021 20:30
@jdtzmn jdtzmn merged commit c3e9456 into develop Mar 22, 2021
@jdtzmn jdtzmn deleted the jacob/logicjs-to-typescript branch March 22, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees

@jdtzmn jdtzmn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate logic.js to TypeScript
2 participants
@jdtzmn @jasonpaulos