Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-Fix: Pass verbosity to the harness and sandbox #630

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented Aug 23, 2022

Summary

Following up from the companion SDK Testing Bugfix PR, we're going to pass through verbosity to the harness script via a new -v flag.

For further context: here is what SDK Testing Bugfix PR says:

The sandbox is always defaulting to release and the generated config.harness isn't sticking because the verbose flag is provided in the wrong order.

Additionally, after refactoring the SDK Sandboxization PR's to no longer overwrite .env, there is no way to pass through the verbosity, except by overwriting. The PR re-enables passing through by also reading VERBOSE_HARNESS as a flag (either -v or --verbose).

@tzaffi tzaffi changed the title Bugfix: Pass verbosity to the harness and sandbox Bug-Fix: Pass verbosity to the harness and sandbox Aug 23, 2022
@tzaffi tzaffi added the Bug-Fix label Aug 23, 2022
@tzaffi tzaffi merged commit 4492e4f into develop Aug 23, 2022
@tzaffi tzaffi deleted the bugfix-passthru-verbosity branch August 23, 2022 22:12
ahangsu added a commit that referenced this pull request Sep 3, 2022
* bump version and add to changelog

* update README.md for new version

* prettier on CHANGELOG

* Update README.md

Co-authored-by: John Lee <john.lee@algorand.com>

* Update README.md

Co-authored-by: John Lee <john.lee@algorand.com>

* Enhancement: Use sandbox for SDK Testing and remove Indexer v1 steps (#623)

* Add files to enable sandbox sdk testing

* Add some todo comments and formatting

* Update changes to script and env

* Delete indexer v1 test steps

* More changes to cucumber tests

* Change features directory in JS SDK

* Remove more indexer integration tests

* Update test env

* Update test-harness.sh

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Break out cucumber tags into their own files (#625)

* Command to generate input for Unused Steps Analysis Script + Remove those steps (#627)

* command to generate input for Unused Steps Analysis Script + Remove those steps

* remvoe the steps

* In response to CR remark. Update Makefile

* Update .test-env

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Bugfix: Pass verbosity to the harness and sandbox (#630)

* Ignore algorand-sdk-testing test-harness dir (#634)

* Enhancement: Deprecating use of langspec (#632)

* enhancement: Initial stateproofs support (#629)

* Initial stateproofs support

* Some more unused steps (#637)

* dummy push

* revert change of dummy push, ci runs now

Co-authored-by: Barbara Poon <barbara.poon@algorand.com>
Co-authored-by: algobarb <78746954+algobarb@users.noreply.github.com>
Co-authored-by: John Lee <john.lee@algorand.com>
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants