-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Code generation improvements #663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - is our new approach to always use generated models for algod/indexer responses going forward?
Generally speaking, yes, I think we should add a js-algorand-sdk/src/client/v2/algod/getApplicationBoxByName.ts Lines 45 to 48 in c104590
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I visually spot-checked several generated examples confirming they match the OpenAPI specification + existing parts of the repo.
This PR contains improvements from algorand/generator#42.