Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug-Fix: encode ABI string with non-ASCII characters #700

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Bug-Fix: encode ABI string with non-ASCII characters #700

merged 3 commits into from
Nov 30, 2022

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Nov 29, 2022

Fixes #699

algochoi
algochoi reviewed Nov 29, 2022
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - nit: I'd also test something like "⚽ 🏃" just so it's a bit clearer we are testing for non-ascii characters like emojis

@ahangsu
Copy link
Contributor Author

ahangsu commented Nov 29, 2022

makes sense, I will add new case once this build passes

algochoi
algochoi approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! :shipit:

jasonpaulos
jasonpaulos approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ahangsu ahangsu merged commit 4f0c9de into develop Nov 30, 2022
@ahangsu ahangsu deleted the utf-8-string-abi branch November 30, 2022 10:36
@michaeldiamant michaeldiamant mentioned this pull request Nov 30, 2022
Merged
@algolucky algolucky mentioned this pull request Dec 5, 2022
Merged
@Roseymr Roseymr mentioned this pull request Sep 16, 2024
Open
@Mustafaovais Mustafaovais mentioned this pull request Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algochoi algochoi algochoi approved these changes

@jasonpaulos jasonpaulos jasonpaulos approved these changes

@michaeldiamant michaeldiamant michaeldiamant approved these changes

@bbroder-algo bbroder-algo Awaiting requested review from bbroder-algo

Assignees
No one assigned
Labels
Bug-Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot encode ABI string with non-ASCII characters
4 participants
@ahangsu @michaeldiamant @jasonpaulos @algochoi