Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow nonParticipation flag to be a boolean #757

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fix: Allow nonParticipation flag to be a boolean #757

merged 2 commits into from
Mar 27, 2023

Conversation

barnjamin
Copy link
Contributor

@barnjamin barnjamin commented Mar 25, 2023 •
edited
Loading

addresses #756

@barnjamin barnjamin changed the title allow nonParticipation flag to be a boolean Fix: allow nonParticipation flag to be a boolean Mar 25, 2023
jasonpaulos
jasonpaulos reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem it solves is that the SDK did not allow you to create offline keyreg transactions, let's be clear about that.

I've verified locally that this works, with a small tweak.

src/makeTxn.ts Outdated Show resolved Hide resolved
@barnjamin barnjamin marked this pull request as ready for review March 27, 2023 16:49
jasonpaulos
jasonpaulos approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Note we'd have discovered this problem earlier if tests/5.Transaction.js was a typescript file. It would be a good idea to convert this and the other JS test files to TS.

@barnjamin barnjamin requested a review from algochoi March 27, 2023 17:00
@barnjamin barnjamin merged commit da815a3 into develop Mar 27, 2023
@barnjamin barnjamin deleted the non-part-type-fix branch March 27, 2023 18:43
@onetechnical onetechnical changed the title Fix: allow nonParticipation flag to be a boolean Fix: Allow nonParticipation flag to be a boolean May 8, 2023
@onetechnical onetechnical mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algochoi algochoi algochoi approved these changes

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
Bug-Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barnjamin @jasonpaulos @algochoi