Client: Don't send auth header when token is empty #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
reviewed
May 12, 2023
tzaffi
reviewed
May 12, 2023
tzaffi
reviewed
May 12, 2023
There was a problem hiding this comment.
Looks good.
I recommend modding the .test-env to temporarily re-point
STD_TESTING_URL="https://github.com/Eric-Warehime/algorand-sdk-testing"
STD_TESTING_BRNACH="client-no-header-tests"so we can see the tests run in CI.
jasonpaulos
reviewed
May 15, 2023
Here is the link to the passing CI w/ test-env pointed at the altered cucumber tests. https://app.circleci.com/pipelines/github/algorand/js-algorand-sdk/1040/workflows/8182c1e1-ef40-4841-bd35-e2163b496ff4 |
jasonpaulos
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #635
This change removes the custom auth headers from requests for all of kmd, algod, and indexer clients.
After removing this we should be sending only standard headers in requests which should avoid the preflight queries mentioned in 635.
I've added cucumber tests in algorand/algorand-sdk-testing#282 and one test in
tests/9.Client.ts