Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algod: Add state delta APIs #785

Merged
merged 4 commits into from
May 24, 2023

Conversation

Eric-Warehime
Copy link
Contributor

Adds new APIs to the algod client:

  • /v2/deltas/{round}
  • /v2/deltas/{round}/txn/group
  • /v2/deltas/txn/group/{id}

Implements the new cucumber tests for the above as well.

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - wondering if ledger state delta objects are not generated below:

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to add statedelta response tag, otherwise LGTM

@@ -24,7 +24,9 @@
@unit.responses.blocksummary
@unit.responses.sync
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider Adding: @unit.responses.statedelta

@Eric-Warehime Eric-Warehime merged commit 97b86ed into algorand:develop May 24, 2023
@Eric-Warehime Eric-Warehime deleted the deltas-apis branch May 24, 2023 20:21
joe-p pushed a commit to joe-p/js-algorand-sdk that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants