Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cross-fetch #833

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

PhearZero
Copy link
Contributor

@PhearZero PhearZero commented Sep 29, 2023

ℹ️ Overview

With the End of Life of Node 16 and engine set to >=18, we can safely use native fetch.

Consumers targeting ie11 or other engines can handle the fetch pollyfill.

📝 Issues

Fixes #823
Relates to #831

test: add node headers

test: add chrome headers
@nullun
Copy link
Contributor

nullun commented Oct 4, 2023

Just want to confirm that this PR fixes #823 and I'll close my revert (#831).

@PhearZero
Copy link
Contributor Author

PhearZero commented Oct 4, 2023

Just want to confirm that this PR fixes #823 and I'll close my revert (#831).

@nullun deployed an example with the following dependency in package.json:

{
  "algosdk": "github:PhearZero/js-algorand-sdk#fix/cross-fetch"
}

And the current render of getTransactionParams : https://wrangler-test.phearzero.workers.dev/

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, happy to remove this dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to execute 'fetch' on 'Window': Illegal invocation
3 participants