Golang 1.17 upgrade #15
Conversation
|
|
||
| require ( | ||
| golang.org/x/mod v0.2.0 // indirect | ||
| golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 // indirect |
There was a problem hiding this comment.
Why is this in a separate require block? did go mod tidy create it this way?
There was a problem hiding this comment.
Yes, it was from running tidy. I left it that way since I liked the fact that direct deps were being separated from indirect. Not aware of whether this is a convention or something we don't do in other repos.
| @@ -4,8 +4,6 @@ | |||
| # Installation can still be performed with a | |||
| # normal `go install`. | |||
|
|
|||
| # generated integration test files | |||
| GGEN = ./_generated/generated.go ./_generated/generated_test.go | |||
There was a problem hiding this comment.
What was the failure that made it so this needed to be removed?
There was a problem hiding this comment.
I assume there will be a lot of them. The code these tests use was ripped out. For example, https://github.com/algorand/msgp/blob/master/_generated/convert_test.go#L13
uses https://github.com/tinylib/msgp/blob/43b487371e0cdd1a3fe1be9a7802d8bce917a1af/msgp/write.go#L118 from the original repository which was removed from our fork in this commit 546fb5f
|
I tested that the generated Going to merge this in and create tag |
Migrate writing build headers from
//+buildto//go:build.This change was made in go1.17 which means it will be backwards incompatible with anything older than that. I have go upgrades for all of go-sdk, go-algorand, and indexer in PR so that shouldn't be a problem.
I also removed all of the _generated tests from the Makefile since they cause
make testto fail.Additionally, I've added coverage output and a unit test for the function I've updated which is currently uncovered (possibly because the _generated tests no longer work.