-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't ignore JSON decoding errors #193
Comments
Hey @jasonpaulos, are you taking PRs for this? I've got two ideas:
Is there a place I should be writing a test for this as well? I can't find it. Happy to contribute a short PR and get familiar with Algorand. |
@jkschin we would definitely appreciate a PR for this! Currently there is no easy way to automate a test for this (unless we can mock algod 🤔), so in this case I'd be inclined to accept a PR without a test. |
Summary
Currently if a JSON algod request cannot parse the response, it just returns
None
:py-algorand-sdk/algosdk/v2client/algod.py
Lines 81 to 84 in 6b304e4
Scope
We should really return an error message in this case instead.
Urgency
It's important to display the proper error if decoding is unsuccessful.
The text was updated successfully, but these errors were encountered: