Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New keyreg txn field #244

Merged
merged 13 commits into from
Feb 14, 2022
Merged

New keyreg txn field #244

merged 13 commits into from
Feb 14, 2022

Conversation

shiqizng
Copy link
Contributor

This PR adds a new field, stateProofKey, to key reg txn to match the changes in algod.

@shiqizng shiqizng self-assigned this Oct 25, 2021
@jasonpaulos jasonpaulos self-requested a review November 1, 2021 23:33
jasonpaulos
jasonpaulos reviewed Nov 2, 2021
View reviewed changes
algosdk/future/transaction.py Outdated Show resolved Hide resolved
algosdk/future/transaction.py Outdated Show resolved Hide resolved
algosdk/future/transaction.py Outdated Show resolved Hide resolved
algosdk/future/transaction.py Outdated Show resolved Hide resolved
jasonpaulos
jasonpaulos reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments on the model file, which I don't think is used anyway

algosdk/v2client/models/account_participation.py Outdated Show resolved Hide resolved
algosdk/v2client/models/account_participation.py Outdated Show resolved Hide resolved
algosdk/v2client/models/account_participation.py Outdated Show resolved Hide resolved
@id-ms id-ms marked this pull request as ready for review January 16, 2022 22:55
jasonpaulos
jasonpaulos reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though once stateproofs are merged into master, I would like to do a quick review again

@jasonpaulos jasonpaulos merged commit 5e8b3a2 into develop Feb 14, 2022
@jasonpaulos jasonpaulos deleted the stateproof branch February 14, 2022 20:28
@onetechnical onetechnical mentioned this pull request Feb 15, 2022
Closed
@algobarb algobarb mentioned this pull request Feb 15, 2022
Merged
@onetechnical onetechnical mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos left review comments

@winder winder winder approved these changes

Assignees

@shiqizng shiqizng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiqizng @winder @jasonpaulos