Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin versions of docs dependencies #279

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

jasonpaulos
Copy link
Contributor

Based on the failed build https://readthedocs.org/projects/pyteal/builds/16655648/, readthedocs is by default installing older versions of the following relevant libraries:

  • sphinx <2
  • sphinx-rtd-theme <0.5

Pinning them to a specific Python 3.10 supported version might fix the build.

Follow up to #276.

Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonpaulos Seems reasonable. Let's try it.

Aside: sphinx-doc/sphinx#9562 suggests 4.2.0 is the minimum version supporting Python 3.10. I see latest release is 4.5.0. We can revisit updating further later on. It feels secondary at best.

@jasonpaulos jasonpaulos merged commit b37b4b5 into master Apr 14, 2022
@jasonpaulos jasonpaulos deleted the fix-readthedocs-build-2 branch April 14, 2022 22:40
algoidurovic pushed a commit to algoidurovic/pyteal that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants