Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVM 8 #439

Merged
merged 27 commits into from
Nov 3, 2022
Merged

AVM 8 #439

merged 27 commits into from
Nov 3, 2022

Conversation

michaeldiamant
Copy link
Contributor

Provides an integration branch for PRs targeting AVM 8.

Relates to #388.

barnjamin and others added 11 commits June 24, 2022 10:05
@barnjamin
upping max teal version
d0f9d8d
@barnjamin
adding program page related ops (#412)
749fb8c 
* adding program page related ops
@jdtzmn @michaeldiamant
Add Replace (#413)
39a11c2 
* Add Replace

* Remove replace auto-import

* Use scripts/generate_init.py

* Add more tests to replace, substring, and extract (#1)

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
@jdtzmn
Add Block (#415)
dd2c7ec 
* Add Block

# Conflicts:
#	pyteal/ir/ops.py

* Disable flake8 errors on formatted lines

* Add past version failure check

* Remove unnecessary ignore Expr equality context
@jdtzmn
Add JsonRef (#417)
8c3d2a0 
* Add JsonRef

* Use named class methods to specify value type

* Remove unnecessary ignore Expr equality context

* Fix docstring link
@jdtzmn
Add Base64Decode (#418)
839b985 
* Add Base64Decode

* Remove unnecessary ignore Expr equality context
@jdtzmn
Support Secp256r1 curve (#423)
7cccdcb 
* Support Secp256r1 curve

* Fix type errors in ecdsa tests

* Fix typo

* Test Secp256k1 curve against TEAL 5 instead

* Add compile check to `MultiValue` class

* Use `MultiValue` compile checks instead of inheritance
@jdtzmn
Add VrfVerify (#419)
9a26fec 
* Add VrfVerify

# Conflicts:
#	pyteal/ast/__init__.py
#	pyteal/ir/ops.py

* Tidy with `MultiValue`’s compile check
@jdtzmn
Add Sha3_256 (#425)
cc544aa 
* Add sha3_256

* Add crypto docs
@jdtzmn
Support FirstValidTime transaction field (#424)
6e83ae6 
* Add first valid time factory and update min version

* Include FirstValidTime in txn tests

* Add transaction field docs
@jdtzmn @michaeldiamant
Add Ed25519Verify_Bare (#426)
594e8e4 
* Add ed25519verify_bare

* Fix typos in Ed25519 docstrings (#2)

* Add crypto doc for Ed25519Verify_Bare

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
@michaeldiamant michaeldiamant mentioned this pull request Jul 13, 2022
Merged
ahangsu and others added 8 commits July 13, 2022 11:18
@ahangsu
Merge branch 'master' into avm8
0ba95e9
@ahangsu
Merge branch 'master' into avm8
e9af25f
@ahangsu @barnjamin
@tzaffi @michaeldiamant
AVM Boxes Ops in Pyteal (#438)
7c24013 
* add box ops

* full support on ops

* first set of test, add versioning in multi

* remove some seemingly not necessary code?

* update testcase

* check invalid arguments

* finish testcase

* move stuffs to app

* version check trick

* verifyTealVersion apply

* error message

* update docs structures

* period

* update doc

* update doc

* update doc

* per pr review on implementation

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* hex box size goes wild

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* warning about MBR

* wording

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* emphasize

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update docs/state.rst

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* polishing

* remove redundant box_put doc segment

* per zeph pr review

* use note and warning

* per zeph's pr review

* Update docs/state.rst

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* creating boxes

* Update docs/state.rst

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* per pr review

* table for state types

Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com>
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
@ahangsu @barnjamin
@michaeldiamant @jdtzmn
Merge Teal7 to AVM8, and consolidate Teal to AVM versioning (#470)
ba260e6 
* swapping base64 modes to match the rest (#446)

* Merge master into teal7 (#450)

* AVM 7:  Address integration branch feedback (#452)

* Add Execute Method (#444)

* adding execute method to allow omission of begin/submit for common use case

* exec docstring

* update testcase

Co-authored-by: Hang Su <hang.su@algorand.com>

* Merge branch 'master' into teal7 (#463)

* fix misspelling of uint (#431)

* fix misspelling of uint

* Clarify minimum Python version management docs (#435)

* Foreign prefix on App and Asset arrays (#440)

* replacing foreignapps with applications

* fix assets as well

* Add Execute Method (#444)

* adding execute method to allow omission of begin/submit for common use case

* exec docstring

* update testcase

Co-authored-by: Hang Su <hang.su@algorand.com>

Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com>
Co-authored-by: Hang Su <hang.su@algorand.com>

* Consolidate TEAL and AVM versioning (#441)

* fix misspelling of uint (#431)

* fix misspelling of uint

* Clarify minimum Python version management docs (#435)

* Convert TEAL version references to program version by hand

* Replace `teal#Options` with `avm#Options`

* Deprecate `*_TEAL_VERSION` in favor of `*_PROGRAM_VERSION`

* Fix docs typo

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* Minor `versions.rst` changes

* Fix `verifyTealVersion` in new opcode files

* Fix linter errors

* Fix language discrepencies introduced by the merge

* Remove incorrect avm replacement

* Fix inconsistent language introduced by merge

Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* max program version

Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
Co-authored-by: Jacob Daitzman <jdtzmn@gmail.com>
@ahangsu
Merge branch 'master' into avm8
ed516f7
@ahangsu
change according to https://github.com/algorand/go-algorand/pull/4323…
055c981 
…/files (#488)
@ahangsu
Merge branch 'master' into avm8-merge-master
bc78e39
@ahangsu
Merge branch 'master' into avm8
2c2b7b2
@ahangsu ahangsu marked this pull request as ready for review September 15, 2022 20:40
@michaeldiamant
Copy link
Contributor Author

I can't approve my own PR, so I leave a comment instead: As of 5282726, the integration branch looks ready to merge once AVM 8 release kicks off.

@jasonpaulos jasonpaulos mentioned this pull request Sep 29, 2022
Merged
jasonpaulos
jasonpaulos reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, I just made a child PR for some docs improvements: #546

ahangsu
ahangsu reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly look good, just one question on acct_params_get op code, and the related fields. Do we want them included in AVM8 release?

@michaeldiamant
Copy link
Contributor Author

just one question on acct_params_get op code, and the related fields. Do we want them included in AVM8 release?

@ahangsu Thanks for flagging it to ensure we cover all the bases.

  • We're working on it, but I do not view it as a blocker to merging the PR. This PR brings a lot of value as is.
  • If the work is done before releasing AVM 8, then we'll happily take the change. Otherwise, we'll include it in a subsequent PyTeal release.

ahangsu
ahangsu approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good about the PR in current shape, approving for I feel like this looks good.

ahangsu and others added 4 commits October 25, 2022 13:24
@ahangsu
Merge branch 'master' into avm8
d767c66
@jdtzmn
Support new AVM 8 account parameters (#555)
cc49a55
@ahangsu
CHANGELOG.md
c241cfa
@ahangsu
Frame Ops to avm8 branch PR (#585)
dd687c7 
* add frame ops to avm8 branch

* specify FRAME_POINTER_VERSION in frame-op branch

* per review comments

* per review comments

* per review comments, depth -> frame_depth

* take bury out

* pop popn

* unexport use of frame ops

* hide FRAME_POINTER_VERISON
ahangsu
ahangsu reviewed Nov 3, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@ahangsu ahangsu merged commit bdcdd5c into master Nov 3, 2022
@ahangsu ahangsu deleted the avm8 branch November 3, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahangsu ahangsu ahangsu approved these changes

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaeldiamant @jasonpaulos @ahangsu @barnjamin @jdtzmn