Add overriding name to method spec so it comes through in contract json

pyteal/ast/router.py

@@ -587,7 +587,7 @@ def add_method_handler(
                 f"with {self.method_selector_to_sig[method_selector]}"
             )
 
-        meth = method_call.method_spec()
+        meth = method_call.method_spec(overriding_name)
         if description is not None:
             meth.desc = description
         self.methods.append(meth)

pyteal/ast/router_test.py

@@ -801,3 +801,24 @@ def clear_state_method():
             assemble_helper(actual_clear_state_with_method)
             == expected_clear_state_with_method
         )
+
+
+def test_override_names():
+
+    router = pt.Router("test")
+
+    @router.method(name="handle")
+    def handle_asa(deposit: pt.abi.AssetTransferTransaction):
+        """handles the deposit where the input is an asset transfer"""
+        return pt.Assert(deposit.get().asset_amount() > pt.Int(0))
+
+    @router.method(name="handle")
+    def handle_algo(deposit: pt.abi.PaymentTransaction):
+        """handles the deposit where the input is a payment"""
+        return pt.Assert(deposit.get().amount() > pt.Int(0))
+
+    _, _, contract = router.compile_program(version=7)
+    assert len(contract.methods) > 0
+    for meth in contract.methods:
+        dmeth = meth.dictify()
+        assert dmeth["name"] == "handle"

pyteal/ast/subroutine.py

@@ -610,7 +610,7 @@ def method_signature(self, overriding_name: str = None) -> str:
             overriding_name = self.name()
         return f"{overriding_name}({','.join(args)}){self.type_of()}"
 
-    def method_spec(self) -> sdk_abi.Method:
+    def method_spec(self, overriding_name: str = None) -> sdk_abi.Method:
         desc: str = ""
         arg_descs: dict[str, str] = {}
         return_desc: str = ""
@@ -674,7 +674,8 @@ def method_spec(self) -> sdk_abi.Method:
             return_obj["desc"] = return_desc
 
         # Create the method spec, adding description if set
-        spec = {"name": self.name(), "args": args, "returns": return_obj}
+        name = overriding_name if overriding_name is not None else self.name()
+        spec = {"name": name, "args": args, "returns": return_obj}
         if desc:
             spec["desc"] = desc
 

pyteal/ast/subroutine_test.py

@@ -1464,3 +1464,14 @@ def withdraw(amount: pt.abi.Uint64, recipient: pt.abi.Account):
         == "An account who will receive the withdrawn Algos. This may or may not be the same as the method call sender."
     )
     assert "desc" not in mspec_dict["returns"]
+
+
+def test_override_abi_method_name():
+    def abi_meth(a: pt.abi.Uint64, b: pt.abi.Uint64, *, output: pt.abi.Uint64):
+        return output.set(a.get() + b.get())
+
+    mspec = ABIReturnSubroutine(abi_meth).method_spec().dictify()
+    assert mspec["name"] == "abi_meth"
+
+    mspec = ABIReturnSubroutine(abi_meth).method_spec("add").dictify()
+    assert mspec["name"] == "add"