-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: native binaries #382
ci: native binaries #382
Conversation
37a4b69
to
2d3117d
Compare
One thing I think is worth considering, perhaps not initially but as a long-term goal, is releases on npm. I think it's safe to assume most Mac devs have brew installed, but the same is not true for windows developers and chocolatey. Having a way to install via brew, pipx, and npm covers a large portion of our developers. Below is a resource I found on distributing binaries through npm |
I guess adding more robust testing setup is already proving to be useful. Caught a new weird bug, @robdmoore i had to lock chore: patching tealer tealer once again. Not really sure yet why the builds used to work prior to recent commits but started failing on 3.12 workers despite previous tests on 3.12. I suspect cache got invalidated and perhaps some related dependencies got refreshed so installing tealer starter breaking on 3.12 again. Tealer has a related repo - added a note to track it. For scope of this pr just gonna patch the ci cd - will open separate pr to rever installation of tealer from our fork on foundation org until tealer team patches the 3.12 completely (we contributed initial efforts as part of 0.1.1 already but looks like it was not enough). Otherwise all comments addressed and retested with release on a fork - merging now |
Proposed changes
Further notes