-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle client generation in a dir containing multiple app spec types #599
Open
neilcampbell
wants to merge
2
commits into
main
Choose a base branch
from
multi-appspec-gen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcampbell
force-pushed
the
multi-appspec-gen
branch
from
December 24, 2024 14:54
ccf0379
to
f457878
Compare
aorumbayev
approved these changes
Dec 24, 2024
app_spec_path_or_dir: Path, | ||
output_path_pattern: str | None, | ||
*, | ||
raise_on_failure: bool, # TODO: NC - Maybe we should return the error instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps another option could be to remove raise_on_failure and add dataclass to represent result from generate_all response that will contain success and failure, something like
class GenerateAllResult:
successful_generations: list[tuple[Path, Path]] # List of (app_spec, output_path) that succeeded
failed_generations: list[tuple[Path, str]] # List of (app_spec, error_message) that failed
@property
def has_failures(self) -> bool:
"""Returns True if any generations failed."""
return len(self.failed_generations) > 0
and then the generate.py would be taking care of deciding when to raise an exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #598