Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set explicit utf-8 encoding as part of writer invocation #27

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix: set explicit utf-8 encoding as part of writer invocation #27

merged 2 commits into from
Jun 13, 2024

Conversation

aorumbayev
Copy link
Contributor

  • Set explicit utf-8 encoding on writer to prevent windows compatibility issues

@github-actions GitHub Actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_client_generator
   __main__.py220%1–3
   cli.py47470%1–81
   document.py82890%44, 47, 49–50, 55, 69, 74–75
   generator.py462699%22, 119, 264, 816, 990, 1005
   spec.py115199%80
   utils.py1081289%24, 41–42, 44, 46, 48, 50, 52, 55–56, 82, 111
TOTAL8337691% 

Tests Skipped Failures Errors Time
42 0 💤 0 ❌ 0 🔥 20.639s ⏱️

@aorumbayev aorumbayev merged commit 002de46 into main Jun 13, 2024
3 checks passed
@aorumbayev aorumbayev deleted the fix/unicode branch June 13, 2024 13:28
@aorumbayev aorumbayev mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdmoore robdmoore robdmoore approved these changes

@neilcampbell neilcampbell neilcampbell approved these changes

@CiottiGiorgio CiottiGiorgio Awaiting requested review from CiottiGiorgio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aorumbayev @robdmoore @neilcampbell